[Pixman] Going to land (Re: [PATCH] mmx/sse2: Use SIMPLE_NEAREST_SOLID_MASK_FAST_PATH for NORMAL repeat)

Pekka Paalanen ppaalanen at gmail.com
Mon Jun 1 04:10:12 PDT 2015


On Mon, 1 Jun 2015 13:40:52 +0300
Siarhei Siamashka <siarhei.siamashka at gmail.com> wrote:

> On Thu, 28 May 2015 16:53:16 +0300
> Pekka Paalanen <ppaalanen at gmail.com> wrote:
> 
> > I have made a branch with my R-b's and amended commit messages at:
> > https://git.collabora.com/cgit/user/pq/pixman.git/log/?h=macro-cleanup
> > 
> > I'll push it early next week, if no-one objects.
> 
> Ben Avison (5):
>   arm: Retire PIXMAN_ARM_SIMPLE_NEAREST_FAST_PATH
>   arm: Simplify PIXMAN_ARM_SIMPLE_NEAREST_A8_MASK_FAST_PATH
>   mips: Retire PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH
>   mmx/sse2: Use SIMPLE_NEAREST_FAST_PATH macro
>   mmx/sse2: Use SIMPLE_NEAREST_SOLID_MASK_FAST_PATH for NORMAL repeat
> 
>  pixman/pixman-arm-common.h | 11 +----------
>  pixman/pixman-arm-neon.c   | 24 ++++++++++++------------
>  pixman/pixman-arm-simd.c   | 18 +++++++++---------
>  pixman/pixman-inlines.h    |  3 ++-
>  pixman/pixman-mips-dspr2.c |  8 ++++----
>  pixman/pixman-mips-dspr2.h |  6 ------
>  pixman/pixman-mmx.c        | 24 ++++--------------------
>  pixman/pixman-sse2.c       | 24 ++++--------------------
>  8 files changed, 36 insertions(+), 82 deletions(-)
> 
> This looks like a nice code cleanup to me (46 lines removed). It is
> still possible that the NORMAL repeat may need special tuning later,
> but this is not a good reason to prevent unification now.
> 
> The whole set is
> Acked-by: Siarhei Siamashka <siarhei.siamashka at gmail.com>
> 

Thank you!

All 5 patches pushed:
   62a772f..eebc1b7  master -> master



Thanks,
pq


More information about the Pixman mailing list