[Pixman] [PATCH 4/5] vmx: fix unused var warnings

Adam Jackson ajax at redhat.com
Wed Jun 17 10:11:07 PDT 2015


On Tue, 2015-06-16 at 18:28 +0300, Oded Gabbay wrote:
> 
> @@ -214,7 +221,7 @@ vmx_combine_over_u_no_mask (uint32_t *      dest,
>  {
>      int i;
>      vector unsigned int vdest, vsrc;
> -    vector unsigned char src_mask;
> +    DECLARE_SRC_MASK_VAR
>  
>      while (width && ((uintptr_t)dest & 15))
>      {

vim (and probably others) get confused about automatic indentation when
you hide semicolons inside macros like this.  Would be better to do:

#if XXX
#define DECLARE_SRC_MASK_VAR vector unsigned char src_mask
#else
#define DECLARE_SRC_MASK_VAR
#endif

...

    DECLARE_SRC_MASK_VAR;

- ajax


More information about the Pixman mailing list