[Pixman] [PATCH 0/5] Fix vmx fast-paths for ppc64le

Fernando Seiti Furusato ferseiti at linux.vnet.ibm.com
Tue Jun 23 06:18:25 PDT 2015


Hello, Oded.

On 06/16/2015 12:27 PM, Oded Gabbay wrote:
> Hi,
>
> This patch-set fixes the vmx fast-paths in regard to ppc64le
> architecture (POWER8).
>
> Although IBM's Fernando Seiti Furusato published a patch concerning this topic,
> it had some problems and I didn't see any "movement" regarding to it for the
> past 2 weeks (since Jun-3).
>
> As I'm working full-time on this issue, I took the liberty to take part of
> Fernando's patch and make it a seperate patch with his name as author.

Thanks for working on this. I didn't find much time to work on this particular
source package and I could not think of a way to keep it all endian agnostic.

>
> The rest of the patches are my own, based on comments made to
> Fernando's original patch and based on my investigations and judgement.

I see that you are actually using _LITTLE_ENDIAN on endianness detection.
Have you seen Siarhei Siamashka's recommendation on using WORDS_BIGENDIAN
instead?

>
> I verified that all the tests work on POWER8 server (with RHEL 7.1 LE) and
> POWER7 server (with REHL 7.1). There is no degredation in performance.
>
> I hope to improve performance in the next patches I will send.
>
> Please review.
>
> Thanks,
>
> 	Oded
>
> Fernando Seiti Furusato (1):
>    vmx: adjust macros when loading vectors on ppc64le
>
> Oded Gabbay (4):
>    vmx: fix splat_alpha for ppc64le
>    vmx: encapsulate the temporary variables inside the macros
>    vmx: fix unused var warnings
>    vmx: fix pix_multiply for ppc64le
>
>   pixman/pixman-vmx.c | 206 +++++++++++++++++++++++++++++++++++++---------------
>   1 file changed, 146 insertions(+), 60 deletions(-)
>

Regards.
-- 

Fernando Seiti Furusato
IBM Linux Technology Center



More information about the Pixman mailing list