[Pixman] [PATCH v2 0/5] Fix vmx fast-paths for ppc64le

Oded Gabbay oded.gabbay at gmail.com
Thu Jun 25 05:59:52 PDT 2015


Here is v2 of my patch-set to fix vmx fast-paths for ppc64le.
The fixes in this v2 are:

- replace _LITTLE_ENDIAN with WORDS_BIGENDIAN for consistency
- fixed whitespaces and indentation issues
- replace #ifndef with #ifdef for readability
- don't put ';' at the end of macro definition. Instead, move it to
  each line the macro is used.

Below is the original patch-set cover-letter

Please review,



This patch-set fixes the vmx fast-paths in regard to ppc64le
architecture (POWER8).

Although IBM's Fernando Seiti Furusato published a patch concerning this topic,
it had some problems and I didn't see any "movement" regarding to it for the
past 2 weeks (since Jun-3).

As I'm working full-time on this issue, I took the liberty to take part of
Fernando's patch and make it a seperate patch with his name as author.

The rest of the patches are my own, based on comments made to
Fernando's original patch and based on my investigations and judgement.

I verified that all the tests work on POWER8 server (with RHEL 7.1 LE) and
POWER7 server (with REHL 7.1). There is no degredation in performance.

I hope to improve performance in the next patches I will send.

Fernando Seiti Furusato (1):
  vmx: adjust macros when loading vectors on ppc64le

Oded Gabbay (4):
  vmx: fix splat_alpha for ppc64le
  vmx: encapsulate the temporary variables inside the macros
  vmx: fix unused var warnings
  vmx: fix pix_multiply for ppc64le

 pixman/pixman-vmx.c | 152 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 119 insertions(+), 33 deletions(-)


More information about the Pixman mailing list