[Pixman] [PATCH 1/5] armv6: Fix typo in preload macro

[Pekka Paalanen]

On Tue,  3 Mar 2015 15:24:16 +0000
Ben Avison <bavison at riscosopen.org> wrote:

> Missing "lsl" meant that cases with a 32-bit source and/or mask, and an
> 8-bit destination, the code would not assemble.
> ---
>  pixman/pixman-arm-simd-asm.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pixman/pixman-arm-simd-asm.h b/pixman/pixman-arm-simd-asm.h
> index 8de060a..da153c3 100644
> --- a/pixman/pixman-arm-simd-asm.h
> +++ b/pixman/pixman-arm-simd-asm.h
> @@ -211,8 +211,8 @@
>          PF  add,    SCRATCH, base, WK0, lsl #bpp_shift-dst_bpp_shift
>          PF  and,    SCRATCH, SCRATCH, #31
>          PF  rsb,    SCRATCH, SCRATCH, WK0, lsl #bpp_shift-dst_bpp_shift
> -        PF  sub,    SCRATCH, SCRATCH, #1    /* so now ranges are -16..-1 / 0..31 / 32..63 */
> -        PF  movs,   SCRATCH, SCRATCH, #32-6 /* so this sets         NC   /  nc   /   Nc   */
> +        PF  sub,    SCRATCH, SCRATCH, #1        /* so now ranges are -16..-1 / 0..31 / 32..63 */
> +        PF  movs,   SCRATCH, SCRATCH, lsl #32-6 /* so this sets         NC   /  nc   /   Nc   */
>          PF  bcs,    61f
>          PF  bpl,    60f
>          PF  pld,    [ptr, #32*(prefetch_distance+2)]

Hi,

this one patch looks like it is independent from the series.

On Sun, 05 Oct 2014 21:03:42 +0200
soren.sandmann at gmail.com (Søren Sandmann) wrote:

> ==================================================================
> 0001:	Typo in preload				Looks good
> ==================================================================
> 
> Looks good

Seems like Søren already agreed. Could this one be pushed alone?


Thanks,
pq