[Pixman] Help with sending patch

Fernando Seiti Furusato ferseiti at linux.vnet.ibm.com
Fri May 22 13:07:35 PDT 2015



On 05/22/2015 04:41 PM, Siarhei Siamashka wrote:
> On Fri, 22 May 2015 13:22:10 -0300
> Fernando Seiti Furusato <ferseiti at linux.vnet.ibm.com> wrote:
>
>> Hello!
>>
>> I work with package porting to ppc64le and I am currently working on pixman.
>> Although the package compiles on the aforementioned architecture, the tests
>> fail.
>
> Hello. Thanks for contacting us. This issue looks very much like
>
>      https://bugs.freedesktop.org/show_bug.cgi?id=87001
Indeed, much probably the same I get here.

>
> At that time it was not very clear whether such hardware really existed
> in the hands of the end users. And the reporter did not seem to be very
> much interested in resolving it.
>
Yes, I think it was more of a rush to get it to build on ppc64le (Breno and I
were still working on making Debian support ppc64le officially).

>> What should be the best way to send that patch?
>
> This is explained in the 'Contributing' and 'Sending patches'
> sections of
>
>      http://cgit.freedesktop.org/pixman/plain/README
>
All right, I will take a look.

> It may take a bit of time to get familiar with this if you have no
> prior experience with git. But on a positive side, many other open
> source projects handle patches in the same way, so it's a generally
> useful knowledge.
>
I couldn't agree more. Will try to make it right at first try :)

>> I appreciate any help on this.
>
> Also before you send the patch, please pay special attention to making
> sure that the Altivec code still works correctly (passes the 'make
> check' test) with all the PPC flavours (big and little endian, 32-bit
> and 64-bit mode). And please mention this in the commit message.
Roger that.

Thank you!
-- 

Fernando Seiti Furusato
IBM Linux Technology Center



More information about the Pixman mailing list