[Pixman] [PATCH] mips: Retire PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH

[Pekka Paalanen]

On Tue, 26 May 2015 23:58:27 +0100
Ben Avison <bavison at riscosopen.org> wrote:

> This macro does exactly the same thing as the platform-neutral macro
> SIMPLE_NEAREST_A8_MASK_FAST_PATH.
> ---
> Question for anyone who can test this code: can working NORMAL repeat
> versions of these operations (over_8888_8_0565 and over_0565_8_0565) be
> added reasonably easily? This would enable the same
> SIMPLE_NEAREST_A8_MASK_FAST_PATH macros to be used for all platforms.
> 
>  pixman/pixman-mips-dspr2.c |    8 ++++----
>  pixman/pixman-mips-dspr2.h |    6 ------
>  2 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/pixman/pixman-mips-dspr2.c b/pixman/pixman-mips-dspr2.c
> index e10c9df..122d9dc 100644
> --- a/pixman/pixman-mips-dspr2.c
> +++ b/pixman/pixman-mips-dspr2.c
> @@ -388,11 +388,11 @@ static const pixman_fast_path_t mips_dspr2_fast_paths[] =
>      SIMPLE_NEAREST_FAST_PATH_PAD (SRC, r5g6b5, a8r8g8b8, mips_0565_8888),
>      SIMPLE_NEAREST_FAST_PATH_PAD (SRC, b5g6r5, a8b8g8r8, mips_0565_8888),
>  
> -    PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, a8r8g8b8, r5g6b5, mips_8888_8_0565),
> -    PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, a8b8g8r8, b5g6r5, mips_8888_8_0565),
> +    SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, a8r8g8b8, r5g6b5, mips_8888_8_0565),
> +    SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, a8b8g8r8, b5g6r5, mips_8888_8_0565),
>  
> -    PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, r5g6b5, r5g6b5, mips_0565_8_0565),
> -    PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, b5g6r5, b5g6r5, mips_0565_8_0565),
> +    SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, r5g6b5, r5g6b5, mips_0565_8_0565),
> +    SIMPLE_NEAREST_A8_MASK_FAST_PATH (OVER, b5g6r5, b5g6r5, mips_0565_8_0565),
>  
>      SIMPLE_BILINEAR_FAST_PATH (SRC, a8r8g8b8, a8r8g8b8, mips_8888_8888),
>      SIMPLE_BILINEAR_FAST_PATH (SRC, a8r8g8b8, x8r8g8b8, mips_8888_8888),
> diff --git a/pixman/pixman-mips-dspr2.h b/pixman/pixman-mips-dspr2.h
> index 955ed70..b9e0684 100644
> --- a/pixman/pixman-mips-dspr2.h
> +++ b/pixman/pixman-mips-dspr2.h
> @@ -328,12 +328,6 @@ FAST_NEAREST_MAINLOOP_COMMON (mips_##name##_pad_##op,                         \
>                                scaled_nearest_scanline_mips_##name##_##op,     \
>                                src_type, uint8_t, dst_type, PAD, TRUE, FALSE)
>  
> -/* Provide entries for the fast path table */
> -#define PIXMAN_MIPS_SIMPLE_NEAREST_A8_MASK_FAST_PATH(op,s,d,func)             \
> -    SIMPLE_NEAREST_A8_MASK_FAST_PATH_COVER (op,s,d,func),                     \
> -    SIMPLE_NEAREST_A8_MASK_FAST_PATH_NONE (op,s,d,func),                      \
> -    SIMPLE_NEAREST_A8_MASK_FAST_PATH_PAD (op,s,d,func)
> -
>  /****************************************************************************/
>  
>  #define PIXMAN_MIPS_BIND_SCALED_BILINEAR_SRC_DST(flags, name, op,            \

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Will push in a few days, if no-one objects.


Thanks,
pq