[Pixman] [RFC PATCH] solid-test: Allow for big-endian targets

Fernando Seiti Furusato ferseiti at linux.vnet.ibm.com
Thu May 28 12:08:55 PDT 2015


Hi Ben.

On 05/28/2015 01:57 PM, Fernando Seiti Furusato wrote:
> Hello Ben.
>
> On 05/27/2015 09:40 AM, Ben Avison wrote:
>> On Tue, 26 May 2015 19:16:32 +0100, I wrote:
>>
>>> +        color.alpha = prng_rand_n (UINT16_MAX);
>>> +        color.red   = prng_rand_n (UINT16_MAX);
>>> +        color.green = prng_rand_n (UINT16_MAX);
>>> +        color.blue  = prng_rand_n (UINT16_MAX);
>>
>> Oops, those should have been UINT16_MAX + 1; the argument is used as a
>> modulo not as a bitmask. The corresponding checksum is then 0xC30FD380
>> for me on ARM and x86 (both little-endian of course).
>>
>> Ben
>> _______________________________________________
>> Pixman mailing list
>> Pixman at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/pixman
>
> I am sorry, I did not receive the original message you sent.
> Luckily I looked in the archive and saw it in the same thread.
> I will be looking into this, thanks for contacting me.

I have just tested that patch with these last adjustments you sent afterwards.
The solid-test passed on all of the 3: ppc64le, ppc64 and powerpc.

Regards.
-- 

Fernando Seiti Furusato
IBM Linux Technology Center



More information about the Pixman mailing list