[Pixman] [PATCH] test: Fix fence-image-self-test on Mac
ppaalanen at gmail.com
Tue Oct 13 05:16:52 PDT 2015
On Tue, 13 Oct 2015 13:41:29 +0200
Andrea Canciani <ranma42 at gmail.com> wrote:
> On Tue, Oct 13, 2015 at 11:39 AM, Pekka Paalanen <ppaalanen at gmail.com>
> > On Tue, 13 Oct 2015 11:07:53 +0200
> > Andrea Canciani <ranma42 at gmail.com> wrote:
> > > On MacOS X an out-of-bounds access to an mmap-ed region typically
> > > results in a SIGBUS, but fence-image-self-test was only accepting a
> > > SIGSEGV as notification of invalid access.
> > Hi,
> > out-of-bounds may be true, but in this case we use mprotect() achieve
> > the same. Up to you if you want to be more accurate in the message, IMO.
> I tried to make the commit message more accurate by quoting from the
> mprotect() manpage.
Yup, looks much better now.
> > Tested to still work on x86_64.
> > With the compiler warning fixed to keep the "\t" correctly:
> > Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Thank you.
> I updated the patch and sent it to the mailing list.
> Together with Matt's patch, it seems to make clang compile fine & pass the
> testsuite on x86_64-apple-darwin14.5.0
Cool, perhaps you intended to CC the mailing list with this note? :-)
Cc'd now. I'll push the fence-image-self-test patch in a few days if
there are no further comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 811 bytes
Desc: OpenPGP digital signature
More information about the Pixman