[Pixman] [PATCH v2 0/3] Add fence_image_create_bits() test helper
ppaalanen at gmail.com
Tue Sep 1 07:24:26 PDT 2015
On Fri, 28 Aug 2015 18:20:31 +0100
"Ben Avison" <bavison at riscosopen.org> wrote:
> On Fri, 28 Aug 2015 12:53:35 +0100, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > This is v2, addressing the review comments from the last time:
> > http://lists.freedesktop.org/archives/pixman/2015-May/003643.html
> The changes all look good to me.
> One minor thing: the self-test spews a lot of text to my console when I'm
> running "make check", whereas none of the other tests do in normal
> functioning (save for an occasional message about the final CRC for some
> tests). I've a feeling this might be something to do with the version of
> autotools I'm running, but if so it might be nice to at least record this
> in a comment somewhere?
oh yeah, I recall hearing that before, can't recall if it was with
Pixman or Weston. "All is going fine" spew on the screen is not good by
default. On my version of autotools, it all goes to the .log file.
I think I need to add a verbose option there. If a test fails on a
SEGV, it's too late to print what it was. Well, I could print but an
option is less complicated.
I'll push patches 1 & 2, and re-send 3.
a82e519..13d93aa master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 811 bytes
Desc: OpenPGP digital signature
More information about the Pixman