[Pixman] [PATCH 3/3] test: Add cover-test v4

Ben Avison bavison at riscosopen.org
Tue Sep 8 06:29:38 PDT 2015

I've reviewed this series and it all looks good to me - with the proviso
that it feels like it's bit odd that there's a difference between:

On Tue, 08 Sep 2015 08:27:36 +0100, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Check the fence page size and skip the test if it is too large.


> Cover-test is still executed even if fenced memory is not available,
> to execute the numerical correctness testing.

The CRC aspect of the test is just as useful if the fence page size is
too large as it is in the case where you can't fence at all. Shouldn't we
either skip the test in both cases or use non-fenced images in both cases?


More information about the Pixman mailing list