[Pixman] [PATCH v2 0/2] over_n_8888 fast path for RaspberryPi

[Pekka Paalanen]

On Thu, 17 Sep 2015 18:01:05 +0300
Oded Gabbay <oded.gabbay at gmail.com> wrote:

> On Thu, Sep 17, 2015 at 5:38 PM, Siarhei Siamashka
> <siarhei.siamashka at gmail.com> wrote:
> > On Thu, 17 Sep 2015 17:04:35 +0300
> > Pekka Paalanen <pekka.paalanen at collabora.co.uk> wrote:
> >
> >> On Mon,  7 Sep 2015 14:40:47 +0300
> >> Pekka Paalanen <ppaalanen at gmail.com> wrote:
> >>
> >> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >> >
> >> > Hi,
> >> >
> >> > this is the second iteration, with the C fast path patch dropped. The remaining
> >> > patches are identical to the previous submission, except they have been
> >> > re-benchmarked, just in case.
> >> >
> >> > Explanation for this patch submission style was given in the previous series:
> >> > http://lists.freedesktop.org/archives/pixman/2015-August/003855.html

> >> Pushed:
> >>    4c71f59..73e586e  master -> master
> >
> > Well, nothing bad has really happened yet. But probably it would be
> > great to give at least a 2 days notice before pushing patches, unless
> > they had been actually reviewed by somebody.
> >
> 
> I thought that Ben wrote the patch and Pekka reviewed it, no ?

Yup. Ben wrote it. I reviewed it (except I can't read asm). We both
benchmarked it, and both our benchmarks agreed. I split it in two
patches that together are equal to Ben's original. I ran it through
'make check' on rpi1 just before pushing. I asked Oded if it's ok to
push these, he said yes. I didn't think it was necessary to ask Ben one
more time "are you sure this code you wrote is good?". I made the
judgement call that after all this it's ripe with just my testing.

I *did* think of posting just a note "going to land soon", but then
thought it's been on the list for 10 days with no comments and it's
already been discussed and accepted. Certainly we have a huge log of
related emails and no-one has objected. After all, the original patch is 
http://patchwork.freedesktop.org/patch/49901/ from 2014.

I'll try to remember to post the going-to-land-soon notes always in the
future.


Thanks,
pq