[Pixman] [PATCH 0/2] Change conditions for setting FAST_PATH_SAMPLES_COVER_CLIP flags v2
oded.gabbay at gmail.com
Sun Sep 20 05:52:21 PDT 2015
On Fri, Sep 11, 2015 at 2:30 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> these two patches supersede the one patch "Change conditions for setting
> FAST_PATH_SAMPLES_COVER_CLIP flags".
> I mainly bikeshedded the comments. I also split it in two, because I realized
> that affine-bench would still work even if it was not patched at the same time.
> I was going to also add a patch to remove the 8e margins from the overflow
> checks in analyze_content(), but then I thought of projective transformations.
> This piece of code is not conditional to the COVER_CLIP flags, so I think it
> applies also to projective transformations. Since I cannot say whether the 8e
> margin is needed, not needed, or misleading (i.e. some margin is needed but not
> 8e), I chose to not include that patch. There are no performance benefits to be
> had, because failing the overflow tests just aborts the whole operation, so
> it's unlikely anyone would be hitting it in the first place.
> I intend to do some Cairo benchmarking with these, too, before I would be ready
> to push these. Will be interesting to see the effects of these and the
> follow-up patches that take the COVER flags even further.
> Ben Avison (2):
> Remove the 8e extra safety margin in COVER_CLIP analysis
> affine-bench: remove 8e margin from COVER area
> pixman/pixman.c | 17 ++++-------------
> test/affine-bench.c | 24 ++++++++++++++++++------
> 2 files changed, 22 insertions(+), 19 deletions(-)
For the series:
Acked-by: Oded Gabbay <oded.gabbay at gmail.com>
More information about the Pixman