[Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

Bill Spitzak spitzak at gmail.com
Tue Sep 22 12:20:28 PDT 2015

On Mon, Sep 21, 2015 at 10:07 PM, Søren Sandmann <soren.sandmann at gmail.com>

> Sure. The extra width check can't harm.

Actually it can, because it implies that such values *can* arrive at this
function, leading programmers to add tests to the calling functions, thus
leading to a large number of tests for conditions that cannot happen.

I would prefer to see an assert(width > 0) there.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20150922/b5ef3b45/attachment.html>

More information about the Pixman mailing list