[Pixman] [PATCH 4/4] Hide the final internal function from global namespace

Emil Velikov emil.l.velikov at gmail.com
Sun Apr 24 18:21:01 UTC 2016


Namely _pixman_internal_only_get_implementation. This workaround is no
longer needed as of last commit, so let's rename the function and make
it truly internal only.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 pixman/pixman-private.h | 7 ++-----
 pixman/pixman-utils.c   | 7 ++-----
 test/combiner-test.c    | 2 +-
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/pixman/pixman-private.h b/pixman/pixman-private.h
index 73a5414..70fa99b 100644
--- a/pixman/pixman-private.h
+++ b/pixman/pixman-private.h
@@ -778,11 +778,8 @@ get_implementation (void)
     return global_implementation;
 }
 
-/* This function is exported for the sake of the test suite and not part
- * of the ABI.
- */
-PIXMAN_EXPORT pixman_implementation_t *
-_pixman_internal_only_get_implementation (void);
+pixman_implementation_t *
+_pixman_get_implementation (void);
 
 /* Memory allocation helpers */
 void *
diff --git a/pixman/pixman-utils.c b/pixman/pixman-utils.c
index 4a3a835..893c5a8 100644
--- a/pixman/pixman-utils.c
+++ b/pixman/pixman-utils.c
@@ -303,11 +303,8 @@ pixman_region32_copy_from_region16 (pixman_region32_t *dst,
     return retval;
 }
 
-/* This function is exported for the sake of the test suite and not part
- * of the ABI.
- */
-PIXMAN_EXPORT pixman_implementation_t *
-_pixman_internal_only_get_implementation (void)
+pixman_implementation_t *
+_pixman_get_implementation (void)
 {
     return get_implementation ();
 }
diff --git a/test/combiner-test.c b/test/combiner-test.c
index 01f63a5..d30da1e 100644
--- a/test/combiner-test.c
+++ b/test/combiner-test.c
@@ -121,7 +121,7 @@ main ()
 
     enable_divbyzero_exceptions();
     
-    impl = _pixman_internal_only_get_implementation();
+    impl = _pixman_get_implementation();
     
     prng_srand (0);
 
-- 
2.8.0



More information about the Pixman mailing list