[Pixman] Pixman Digest, Vol 71, Issue 16

[Nick Godby]

Thanks =)


On Sun, Jan 17, 2016 at 2:00 PM, <pixman-request at lists.freedesktop.org>
wrote:

> Send Pixman mailing list submissions to
>         pixman at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         http://lists.freedesktop.org/mailman/listinfo/pixman
> or, via email, send a message with subject or body 'help' to
>         pixman-request at lists.freedesktop.org
>
> You can reach the person managing the list at
>         pixman-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Pixman digest..."
>
>
> Today's Topics:
>
>    1. [PATCH] pixman-private: include <float.h> only in C code
>       (Thomas Petazzoni)
>    2. [PATCH] configure: add options to disable demos and tests
>       (Thomas Petazzoni)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 17 Jan 2016 15:22:50 +0100
> From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> To: pixman at lists.freedesktop.org
> Subject: [Pixman] [PATCH] pixman-private: include <float.h> only in C
>         code
> Message-ID:
>         <
> 1453040570-28760-1-git-send-email-thomas.petazzoni at free-electrons.com>
>
>
> <float.h> is included unconditionally by pixman-private.h, which in
> turn gets included by assembler files. Unfortunately, with certain C
> libraries (like the musl C library), <float.h> cannot be included in
> assembler files:
>
>   CCLD     libpixman-arm-simd.la
> /home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:
> Assembler messages:
> /home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:8:
> Error: bad instruction `int __flt_rounds(void)'
> /home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:
> Assembler messages:
> /home/test/buildroot/output/host/usr/arm-buildroot-linux-musleabihf/sysroot/usr/include/float.h:8:
> Error: bad instruction `int __flt_rounds(void)'
>
> It turns out however that <float.h> is not needed by assembly files,
> so we move its inclusion within the #ifndef __ASSEMBLER__ condition,
> which solves the problem.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  pixman/pixman-private.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/pixman/pixman-private.h b/pixman/pixman-private.h
> index 73108a0..73a5414 100644
> --- a/pixman/pixman-private.h
> +++ b/pixman/pixman-private.h
> @@ -1,5 +1,3 @@
> -#include <float.h>
> -
>  #ifndef PIXMAN_PRIVATE_H
>  #define PIXMAN_PRIVATE_H
>
> @@ -30,6 +28,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <stddef.h>
> +#include <float.h>
>
>  #include "pixman-compiler.h"
>
> --
> 2.6.4
>
>
>
> ------------------------------
>
> Message: 2
> Date: Sun, 17 Jan 2016 15:31:47 +0100
> From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> To: pixman at lists.freedesktop.org
> Subject: [Pixman] [PATCH] configure: add options to disable demos and
>         tests
> Message-ID:
>         <
> 1453041107-4711-1-git-send-email-thomas.petazzoni at free-electrons.com>
>
> On certain architectures, the functionality of <fenv.h> may not be
> available, which prevents building the pixman tests. In order to still
> allow building pixman easily on such platforms, this commit adds two
> new configure options, --disable-testprogs and --disable-demos, which
> can be used to disable building the test and demo programs
> respectively.
>
> Of course, by default, tests and demo programs continue to be built,
> so that the existing behavior is preserved.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  Makefile.am  | 10 +++++++++-
>  configure.ac | 18 ++++++++++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5137c9e..cc29a75 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,4 +1,12 @@
> -SUBDIRS = pixman demos test
> +SUBDIRS = pixman
> +
> +if DEMOS
> +SUBDIRS += demos
> +endif
> +
> +if TESTPROGS
> +SUBDIRS += test
> +endif
>
>  pkgconfigdir=$(libdir)/pkgconfig
>  pkgconfig_DATA=pixman-1.pc
> diff --git a/configure.ac b/configure.ac
> index 6b2134e..0e4d929 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -807,6 +807,24 @@ fi
>  AM_CONDITIONAL(USE_GCC_INLINE_ASM, test $have_gcc_inline_asm = yes)
>
>  dnl ==============================================
> +dnl Demos
> +AC_ARG_ENABLE(demos,
> +  [AC_HELP_STRING([--disable-demos],
> +                  [build demos [default=yes]])],
> +  [enable_demos=$enableval], [enable_demos=yes])
> +
> +AM_CONDITIONAL(DEMOS, test $enable_demos = yes)
> +
> +dnl ==============================================
> +dnl Test programs
> +AC_ARG_ENABLE(testprogs,
> +  [AC_HELP_STRING([--disable-testprogs],
> +                  [build test programs [default=yes]])],
> +  [enable_testprogs=$enableval], [enable_testprogs=yes])
> +
> +AM_CONDITIONAL(TESTPROGS, test $enable_testprogs = yes)
> +
> +dnl ==============================================
>  dnl Static test programs
>
>  AC_ARG_ENABLE(static-testprogs,
> --
> 2.6.4
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pixman
>
>
> ------------------------------
>
> End of Pixman Digest, Vol 71, Issue 16
> **************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20160117/d6b01267/attachment.html>