[Pixman] [PATCH v13 11/14] pixman-filter: Negative subsample values produces scaled result

[Søren Sandmann]

On Tue, Feb 16, 2016 at 4:45 PM, Bill Spitzak <spitzak at gmail.com> wrote:

> I have a new version of this patch, which fixes a math error that
> caused it to produce too many samples at small sizes (large scales). I
> am not clear if I can submit a v14 of just this patch or I should
> instead submit a v14 of the entire patch series.
>

I don't think this functionality belongs in pixman at all. Computing the
number of subsamples is essentially a performance/quality tradeoff, which
is something that cairo and other clients need to make for themselves. In
general, pixman is not the place for heuristics; its API should be
predictable and explicit.

So, NACK from me on this patch.


Søren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160304/f0c38857/attachment.html>