[Pixman] [PATCHv2 1/3] pixman-fast-path.c: Pick NEAREST affine fast paths before BILINEAR ones

[Bill Spitzak]

Looks correct to me, and a really good idea. I noticed this but did not
know how to fix it, so I had to make sure only one optimization flag was
turned on. The ability to turn on multiple ones is a lot better.

On Wed, Mar 16, 2016 at 9:14 PM, Søren Sandmann Pedersen <
soren.sandmann at gmail.com> wrote:

> When a BILINEAR filter is reduced to NEAREST, it is possible for both
> types of fast paths to run; in this case, the NEAREST ones should be
> preferred as that is the simpler filter.
>
> Signed-off-by: Soren Sandmann <soren.sandmann at gmail.com>
> ---
>  pixman/pixman-fast-path.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pixman/pixman-fast-path.c b/pixman/pixman-fast-path.c
> index 53d4a1f..b4daa26 100644
> --- a/pixman/pixman-fast-path.c
> +++ b/pixman/pixman-fast-path.c
> @@ -3258,9 +3258,9 @@ static const pixman_iter_info_t fast_iters[] =
>      },
>
>  #define AFFINE_FAST_PATHS(name, format, repeat)
>       \
> -    SEPARABLE_CONVOLUTION_AFFINE_FAST_PATH(name, format, repeat)       \
> +    NEAREST_AFFINE_FAST_PATH(name, format, repeat)                     \
>      BILINEAR_AFFINE_FAST_PATH(name, format, repeat)                    \
> -    NEAREST_AFFINE_FAST_PATH(name, format, repeat)
> +    SEPARABLE_CONVOLUTION_AFFINE_FAST_PATH(name, format, repeat)
>
>      AFFINE_FAST_PATHS (pad_a8r8g8b8, a8r8g8b8, PAD)
>      AFFINE_FAST_PATHS (none_a8r8g8b8, a8r8g8b8, NONE)
> --
> 1.7.11.7
>
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pixman
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160317/a54f1bf0/attachment.html>