[Pixman] [PATCH 1/4] Implement floating point gradient computation

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Tue Dec 4 16:36:18 UTC 2018


Hey,

Op 03-12-2018 om 16:01 schreef Basile Clement:
>
> This is essentially a duplicate of the recent patch by Maarten Lankhorst (which spurred me into finally posting these, which laid on my laptop for a couple months), with a slightly different approach.  It is mostly included as it is a prerequisite for the subsequent patches, but they should work just as well with Maarten's patch.
>
> This series of patches is driven by a discussion with Marc Jeanmougin and the need of having dithering in pixman for inkscape, and tries to implement the recommendations given by Soren in previous threads on the topic.
>
Series looks sane, 1/4 is cleaner than my version. I would change Bpp to cpp, or multiply by 8, since Bpp usually means bits per pixel.

Do you happen to have a patch to fix pixman-bits-image.c falling back to 8-bit paths as well?

~Maarten



More information about the Pixman mailing list