[Pixman] [PATCH] test: Adjust for clang's removal of __builtin_shuffle

Adam Jackson ajax at redhat.com
Mon Jun 4 17:37:48 UTC 2018


On Mon, 2018-06-04 at 10:04 -0700, Matt Turner wrote:

> #ifdef HAVE_GCC_VECTOR_EXTENSIONS
> -            const uint8x16 bswap_shufflemask =
> +# if __has_builtin(__builtin_shufflevector)
> +            randdata.vb =
> +                __builtin_shufflevector (randdata.vb, randdata.vb,
> +                                          3,  2,  1,  0,  7,  6 , 5,  4,
> +                                         11, 10,  9,  8, 15, 14, 13, 12);
> +# else
> +            static const uint8x16 bswap_shufflemask =
  ^            ^^^^^^

Seems superfluous, though I guess it doesn't change semantics. With or
without that bit:

Reviewed-by: Adam Jackson <ajax at redhat.com>

I think we're starting to be well overdue for an 0.36 release, but I'd
like to take the opportunity to suggest moving to fdo's gitlab as we do
that. I already have a copy imported personally and have CI working:

https://gitlab.freedesktop.org/ajax/pixman/-/jobs/986

- ajax


More information about the Pixman mailing list