[Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image, v2.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon Feb 11 12:40:20 UTC 2019

Op 09-02-2019 om 13:01 schreef Basile Clement:
> On 1/8/19 11:42 AM, Maarten Lankhorst wrote:
>> pixman-bits-image's wide helpers first obtains the 8-bits image,
>> then converts it to float. This destroys all the precision that
>> the wide path was offering.
>> Fix this by making get_pixel() take a pointer instead of returning
>> a value. Floating point will fill in a argb_t, while the 8-bits path
>> will fill a 32-bits ARGB value. This also requires writing a floating
>> point bilinear interpolator. With this change pixman can use the full
>> floating point precision internally in all paths.
>> Changes since v1:
>> - Make accum and reduce an argument to convolution functions,
>>   to remove duplication.
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Apologies for the late reply; I have been quite busy with other things
> recently.
> The patch looks good to me now!  I have not figured out how to visually
> test the filters however.

Thanks, pushed.

Can you rebase the dithering patches so I can take a look?


More information about the Pixman mailing list