[Pixman] [PATCH] void function should not return a value

[Niveditha Rau]

On 02/22/2019 01:51 PM, Simon Richter wrote:
> Hi,
>
> On 22.02.19 22:48, Niveditha Rau wrote:
>
>> When compiling pixman with Oracle Developer Studio on Solaris, we get
>> the following error:
>> pixman-0.38.0/pixman/pixman-radial-gradient.c", line 114: void function
>> cannot return value
>> Would the attached patch be acceptable upstream?
> No, because the flow is different. It'd have to be
>
>   	if (repeat == PIXMAN_REPEAT_NONE)
>   	{
>   	    if (0 <= t && t <= pixman_fixed_1)
> +           {
> -		return write_pixel (walker, t, buffer);
> +		write_pixel (walker, t, buffer);
> +               return;
> +           }
>   	}
>
ok, thanks.  Please find attached a reworked patch.

Thanks
Niveditha

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-void-function-should-not-return-a-value.patch
Type: text/x-patch
Size: 1715 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20190222/3ae10c35/attachment.bin>