[Pixman] [PATCH 2/3] Moving helper functions in pixman-sse2.c to pixman-sse2.h.

Devulapalli, Raghuveer raghuveer.devulapalli at intel.com
Thu Jan 17 17:30:42 UTC 2019


Sounds good to me. I made the minor fixes. I can submit new patches for merging if everything else looks okay. 

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk] 
Sent: Thursday, January 17, 2019 12:27 AM
To: Devulapalli, Raghuveer <raghuveer.devulapalli at intel.com>; pixman at lists.freedesktop.org
Cc: Devulapalli, Raghuveer <raghuveer.devulapalli at intel.com>
Subject: Re: [Pixman] [PATCH 2/3] Moving helper functions in pixman-sse2.c to pixman-sse2.h.

Quoting Raghuveer Devulapalli (2019-01-17 00:59:59)
> From: raghuveer devulapalli <raghuveer.devulapalli at intel.com>
> 
> These helper function will be reused in pixman-avx2.c implementations 
> in the future.

Are we ever going to run into a naming conflict in the future? Is it worth prefixing all the inlines with sse2_? Probably makes sense so that we can see the instruction set used when mixing later.
-Chris


More information about the Pixman mailing list