[Pixman] Broken colours on big endian machines since b4a105d

[Jocelyn Falempe]

On 14/12/2022 09:09, Pekka Paalanen wrote:
> On Tue, 13 Dec 2022 15:08:41 -0500
> Søren Sandmann <soren.sandmann at gmail.com> wrote:
> 
>> The commit in question is definitely broken and will cause wrong
>> colors of scaled images on big-endian, but I'm not sure who can do
>> anything about it these days.
> 
> Let's at least add the mentioned author in CC here, like this.

I'm sorry it breaks things for you.
I've tested this on s390x big endian machine, and though that was the 
right place to fix. But I'm not a pixman expert, so I'm probably wrong.

Which application are you using ? Does gnome-character has the right 
colors for you ?

On s390x, most images in firefox are also color-inverted, but I wasn't 
able to fix that.

Feel free to propose a revert.

Best regards,

-- 

Jocelyn




> 
> 
> Thanks,
> pq
> 
>> On Tue, Dec 13, 2022 at 11:40 AM Martin Husemann <martin at netbsd.org> wrote:
>>>
>>> On Sun, Dec 04, 2022 at 11:03:30AM +0100, Martin Husemann wrote:
>>>> Hey folks,
>>>>
>>>> the commit
>>>>
>>>> https://github.com/freedesktop/pixman/commit/b4a105d77232a87304b7b621e2f99e699a8eebd3
>>>>
>>>> breaks pixman for me on NetBSD/macppc in exactly the way it says it would
>>>> fix things: colours of scaled images are now wrong, this is noticable for
>>>> example with firefox and favicons displayed on the tab (for sites that
>>>> use coloured and bigger favicons), but also for some scaled images.
>>>
>>> Tap... tap... tap... - is this list alive?
>>>
>>> Martin
>