<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 4, 2016 at 2:52 PM, Søren Sandmann <span dir="ltr"><<a href="mailto:soren.sandmann@gmail.com" target="_blank">soren.sandmann@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Feb 10, 2016 at 1:25 AM, <span dir="ltr"><<a href="mailto:spitzak@gmail.com" target="_blank">spitzak@gmail.com</a>></span> wrote:<br></span><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Bill Spitzak <<a href="mailto:spitzak@gmail.com" target="_blank">spitzak@gmail.com</a>><br>
<br>
Rearranged so that the entire block of memory for the filter pair<br>
is allocated first, and then filled in. Previous version allocated<br>
and freed two temporary buffers for each filter and did an extra<br>
memcpy.<br>
<br>
v8: small refactor to remove the filter_width function<br>
<br>
v10: Restored filter_width function but with arguments changed to<br>
match later patches<br>
<br>
v11: Removed unused arg and pointer from filter_width function<br>
Whitespace fixes.<br>
<br>
Signed-off-by: Bill Spitzak <<a href="mailto:spitzak@gmail.com" target="_blank">spitzak@gmail.com</a>><br>
Reviewed-by: Oded Gabbay <<a href="mailto:oded.gabbay@gmail.com" target="_blank">oded.gabbay@gmail.com</a>><br></blockquote></span><div><br>I'm not opposed to this
patch if it is correct (and I'll believe the existing Reviewed-by for
correctness), but I'm also don't think there is much point to this -- these malloc() and free() calls are unlikely to be performance
bottlenecks.<br><span><div><br></div></span><div>Acked-by: Soren Sandmann <<a href="mailto:soren.sandmann@gmail.com" target="_blank">soren.sandmann@gmail.com</a>></div></div></div></div></div></blockquote><div><br></div><div>This is certainly correct, it would have been obvious in my tests if it did not work.</div><div><br></div></div></div></div>