<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>Can I get any input if my second patch follows "the right
approach"? Are there any astylerc or clang_format to check that my
code complies with code style ?</p>
<p>Thanks<br>
</p>
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 04/19/2018 08:41 PM, Marc Jeanmougin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:a14e5b50-14dc-5b11-2451-b5fa3c68328d@jeanmougin.fr">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p>Hi, <br>
</p>
<p>Could anyone help me from here? If there is still a fundamental
problem with the patch, I'll be happy to rework it (or if there
is anything more needed in it) <br>
</p>
<p>From what I gathered, pixman is without maintainer, so I'm not
sure either how to proceed or who to contact...</p>
<p>-- <br>
</p>
<p>Marc<br>
</p>
<br>
<div class="moz-cite-prefix">On 04/08/2018 10:46 PM, Marc
Jeanmougin wrote:<br>
</div>
<blockquote type="cite"
cite="mid:27a1ceca-3f27-ffcb-b597-429ec7a1d686@jeanmougin.fr">
<pre wrap="">Hi, I'm back :)
I tried to implement the proposed changes :
* the gradient walker now deals with argb_t (floats) and not uint32_t
* all gradients are WIDE because of the above change
* WIDE formats (using argb_t) can be dithered on write_back call
depending on the "dither" property of the image (set with
pixman_image_set_dither)
* The dithering is still random. I could try to implement other ones if
it's really needed for the patch to be accepted
Thanks for any feedback, please do tell if there are any more changes
needed for the patch to be accepted.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pixman mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pixman@lists.freedesktop.org" moz-do-not-send="true">Pixman@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/pixman" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/pixman</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pixman mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pixman@lists.freedesktop.org">Pixman@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/pixman">https://lists.freedesktop.org/mailman/listinfo/pixman</a>
</pre>
</blockquote>
<br>
</body>
</html>