[PATCH][W32] W32 and MSys compatibility

[LRN]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18.05.2012 20:36, Dan Nicholson wrote:
> On Fri, May 18, 2012 at 09:21:08AM -0700, Dan Nicholson wrote:
>> On Sat, Mar 31, 2012 at 09:27:54AM +0400, LRN wrote:
>>> 09-fix-pkgconfig-pc-path-on.mingw32.patch: Can't use deprecated
>>> w32 functions with new glib :( Also leaks a bit less memory (no
>>> that anyone would notice...)
>> 
>> This one is also in bug 45742. I liked your version of the patch
>> better where a separate symbol was added. However, I like it even
>> more if we always use the symbol and only use the conditional
>> once when it's constructed. I also added a version check for glib
>> in configure to make sure we have a new enough version.
>> 
>> Can you give the attached patch a shot and let me know if it
>> works?
> 
> Whoops, I missed a conditional in pkg.c I wanted to fix. Can you
> try this patch?
It compiles (against external glib). And passes all 12 tests. I'll
install the compiled binaries into my buildslave to see how they work

When compiling with internal glib, requires linking to libintl (glib
itself does know how to link to libintl, but since internal glib is
compiled and linked statically, it does not pull libintl linkage along
with it the way shared glib would). You probably need to pass
- --disable-nls to glib configure to force it to define all
gettext-related functions to noops.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPt9S4AAoJEOs4Jb6SI2Cw4SAH/1PJh1HEap+hYMwF8q2Wy9zM
NVz1NuVzqtmrLHBZKmi523bQxLL3Sl31Kb1YrvAQCtYafUzVLryb1bZYQZJuKt6j
Ez9ncK2sQEpoMaWnuO5SWyiutdtvkICTITvlBNgN5n62JrBcQYV8q08SaEVRzy8v
76medZrsry074tcnjKMDQL5WQpQrOFHP+IEcB0XmtFtqgT7Epb7DWFzIVVzWd5DO
/gN4Wmi6kp/Q7AFi0B0D+W7IXOVtY8qdb6o1EaWxV6HsmC+hLLUGDgUX14FepeLt
TjTmWyKtSgrvXudxkAiB1oWbIP/PcH29mi9mM8/9BATf0GjDD380zXbnegL6d0c=
=8sIh
-----END PGP SIGNATURE-----