[PATCH] Fix memory leak and add small optiomization

Dan Nicholson nicholson at endlessm.com
Mon Aug 22 22:06:02 UTC 2016


Hi Marco,

Thanks for sending the patch. Here are some comments.

1. I'd prefer to keep the searching done the way it is where the
packages hash table is searched rather than open coding the checks in
has_required_packages. That duplicates too much of the logic in a way
that's likely to break. In that sense, I'd prefer to skip the
optimization where package_init isn't run immediately.

2. The leak can be fixed by simply calling g_list_free at the end of
process_package_args, right?

Thanks,
Dan
--
Dan Nicholson  |  +1.206.437.0833  |  Endless


On Sat, Aug 20, 2016 at 11:20 AM, Marco Diego Aurélio Mesquita
<marcodiegomesquita at gmail.com> wrote:
> Hi devs!
>
> Just updated the patch so that the tests are happy.
>
> Please, review it.
>
> _______________________________________________
> pkg-config mailing list
> pkg-config at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pkg-config
>


More information about the pkg-config mailing list