[PATCH] Optimization to avoid scanning all .pc files
Marco Diego Aurélio Mesquita
marcodiegomesquita at gmail.com
Sat Aug 27 14:53:37 UTC 2016
Hi Devs!
Attached is just a small improvement to the patch: code improvements
and path_position calculation is smarter. I think it is now good to
go.
Please review it.
On Fri, Aug 26, 2016 at 10:04 PM, Marco Diego Aurélio Mesquita
<marcodiegomesquita at gmail.com> wrote:
> Hi Matthew!
>
> Thanks for the review. The attached patch implements the changes you asked.
>
> Is there anything else that should be changed?
>
> On Fri, Aug 26, 2016 at 8:25 PM, Matthew Hanna (BLOOMBERG/ 731 LEX)
> <mhanna21 at bloomberg.net> wrote:
>> --- Original Sender: INTERNET2 .PROG/MSG/INT, BLOOMBERG/ 330 WEST ---
>>
>> The call to 'access' should be replaced by 'g_file_test' for portability and/or platform optimization.
>>
>> Are there whitespace changes in the diff? If so, please remove. It makes the diff very hard to read.
>>
>> ---
>> Sent from Bloomberg Professional for Android
>>
>>
>> ----- Original Message -----
>> FROM: Marco Diego Aurélio Mesquita <marcodiegomesquita at gmail.com>
>> At: 27-Aug-2016 01:03:59
>>
>> Hi devs!
>>
>> The attached patch improves pkg-config so that it will look for
>> required .pc files only, instead of loading and parsing all known .pc
>> files.
>>
>> Please review it.
>>
>> ----------------------------
>>
>> _______________________________________________
>> pkg-config mailing list
>> pkg-config at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/pkg-config
>> _______________________________________________
>> pkg-config mailing list
>> pkg-config at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/pkg-config
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pkg-config-optimization-5.patch
Type: text/x-patch
Size: 6782 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pkg-config/attachments/20160827/dc5a84df/attachment.bin>
More information about the pkg-config
mailing list