Remove one more unneeded hashtable

Marco Diego Aurélio Mesquita marcodiegomesquita at
Wed May 9 15:11:24 UTC 2018

Hi Devs!

Please consider the attached patch.

The old algorithm for dependency checking in pkg-config used a boolean
member on the Packages structure (in_requires_chain) to check if a
package was already on the "requires chain". The problem with the old
algorithm was that such member was reset at the end of
recursive_fill_list. Matthew Hanna fixed such problem by using a
hashtable (in 908cdd), but this can actually be done the old way
(without any hashtable) if the boolean member is reset at the right

The attached patch brings such a member back, resets it on the right
places and removes the need for another hashtable.

Please review it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: one-less-hashtable.patch
Type: text/x-patch
Size: 4566 bytes
Desc: not available
URL: <>

More information about the pkg-config mailing list