<html><head><title></title></head><body><div class="rte-style-maintainer" style="font-family: Arial; white-space: pre-wrap; font-size: small; color: rgb(0, 0, 0);"data-color="global-default" bbg-color="default" data-bb-font-size="medium" bbg-font-size="medium" bbg-font-family="normal">Results of tests of this patch on our system are mixed. The optimization does<div>not appear to be needed on our Linux boxes. The time to read our pkgconfig</div><div>directory is in the milliseconds. On other platforms, the time is in seconds,</div><div>so I was hopeful that this patch would reduce that time. It certainly reduces</div><div>the minimum speed, but the maximum speed is actually increased. In one test,</div><div>the time without the patch is 2 seconds, with almost all of that time taken up</div><div>by the directory reading. With the patch, the minimum time is now in</div><div>milliseconds for a low level library with few dependencies, but is now over 5</div><div>seconds for a higher level library.<br><div class="rte-style-maintainer" style="font-size: small; font-family: 'Courier New', Courier; color: rgb(0, 0, 0);"data-color="global-default" bbg-color="default" data-bb-font-size="medium" bbg-font-size="medium" bbg-font-family="fixed-width"><br><div class="bbg-rte-fold-content" data-header="From: marcodiegomesquita@gmail.com At: 08/27/16 10:53:48"data-digest="From: marcodiegomesquita@gmail.com At: 08/27/16 10:53:48" style=""><div class="bbg-rte-fold-summary">From: marcodiegomesquita@gmail.com At: 08/27/16 10:53:48</div><div>To: <a spellcheck="false" bbg-destination="mailto:mhanna21@bloomberg.net" href="mailto:mhanna21@bloomberg.net">Matthew Hanna (BLOOMBERG/ 731 LEX)</a>, <a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:nicholson@endlessm.com">nicholson@endlessm.com</a><br>Cc: <a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:pkg-config@lists.freedesktop.org">pkg-config@lists.freedesktop.org</a><br>Subject: Re: [PATCH] Optimization to avoid scanning all .pc files<br></div></div><blockquote>Hi Devs!<br><br><br>Attached is just a small improvement to the patch: code improvements<br>and path_position calculation is smarter. I think it is now good to<br>go.<br><br>Please review it.<br><br><br>On Fri, Aug 26, 2016 at 10:04 PM, Marco Diego Aurélio Mesquita<br><<a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:marcodiegomesquita@gmail.com" data-destination="mailto:rte:bind">marcodiegomesquita@gmail.com</a>> wrote:<br>> Hi Matthew!<br>><br>> Thanks for the review. The attached patch implements the changes you asked.<br>><br>> Is there anything else that should be changed?<br>><br>> On Fri, Aug 26, 2016 at 8:25 PM, Matthew Hanna (BLOOMBERG/ 731 LEX)<br>> <<a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:mhanna21@bloomberg.net" data-destination="mailto:rte:bind">mhanna21@bloomberg.net</a>> wrote:<br>>> --- Original Sender: INTERNET2 .PROG/MSG/INT, BLOOMBERG/ 330 WEST ---<br>>><br>>> The call to 'access' should be replaced by 'g_file_test' for portability and/or platform optimization.<br>>><br>>> Are there whitespace changes in the diff? If so, please remove. It makes the diff very hard to read.<br>>><br>>> ---<br>>> Sent from Bloomberg Professional for Android<br>>><br>>><br>>> ----- Original Message -----<br>>> FROM: Marco Diego Aurélio Mesquita <<a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:marcodiegomesquita@gmail.com" data-destination="mailto:rte:bind">marcodiegomesquita@gmail.com</a>><br>>> At: 27-Aug-2016 01:03:59<br>>><br>>> Hi devs!<br>>><br>>> The attached patch improves pkg-config so that it will look for<br>>> required .pc files only, instead of loading and parsing all known .pc<br>>> files.<br>>><br>>> Please review it.<br>>><br>>> ----------------------------<br>>><br>>> _______________________________________________<br>>> pkg-config mailing list<br>>> <a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:pkg-config@lists.freedesktop.org" data-destination="mailto:rte:bind">pkg-config@lists.freedesktop.org</a><br>>> <a bbg-destination="rte:bind"spellcheck="false" href="https://lists.freedesktop.org/mailman/listinfo/pkg-config"data-destination="rte:bind">https://lists.freedesktop.org/mailman/listinfo/pkg-config</a><br>>> _______________________________________________<br>>> pkg-config mailing list<br>>> <a spellcheck="false"bbg-destination="mailto:rte:bind" href="mailto:pkg-config@lists.freedesktop.org" data-destination="mailto:rte:bind">pkg-config@lists.freedesktop.org</a><br>>> <a bbg-destination="rte:bind"spellcheck="false" href="https://lists.freedesktop.org/mailman/listinfo/pkg-config"data-destination="rte:bind">https://lists.freedesktop.org/mailman/listinfo/pkg-config</a><br></blockquote><br></div></div></div></body></html>