[PATCH 3/9] add support for long data types

Ray Strode halfline at gmail.com
Mon Feb 23 13:15:41 PST 2009


Hi,

On Mon, Feb 23, 2009 at 3:35 PM,  <william.jon.mccann at gmail.com> wrote:
> From: William Jon McCann <jmccann at redhat.com>

Could use a description here.  Maybe just say why you need longs supported?

If this is just for the ptmx variable, i'd say lets drop this patch entirely and
make ptmx an int like it should have been to begin with.

> ---
>  src/libply/ply-command-parser.c |   37 +++++++++++++++++++++++++++++++++++++
>  src/libply/ply-command-parser.h |    3 ++-
>  2 files changed, 39 insertions(+), 1 deletions(-)
>
> diff --git a/src/libply/ply-command-parser.c b/src/libply/ply-command-parser.c
> index 29d47fa..5d77e00 100644
> --- a/src/libply/ply-command-parser.c
> +++ b/src/libply/ply-command-parser.c
> @@ -38,6 +38,7 @@ typedef union
>   bool as_boolean;
>   char *as_string;
>   int as_integer;
> +  int as_long;
>  } ply_command_option_result_t;
Presumably, the "int as_long" should be "long as_long", no?
The rest of the patch looks okay.

--Ray


More information about the plymouth mailing list