X11 test renderer

[Ray Strode]

Hi,

On Sun, Oct 4, 2009 at 8:10 AM, Charlie Brej <plymouth at brej.org> wrote:
> On 04/10/09 03:16, Ray Strode wrote:
>>
>> In your Xorg.0.log do you see:
>
> Nothing in the logs apart from the usual.
Okay so it wasn't that same driver issue from the bug reports then.

>> I pushed this.  There was also a problem where I was still doing
>> gdk_window_clear on the whole window.  I pushed a fix for that, too.
>
> Brilliant, that one fixed it.
Great.  Honestly, I'm a little surprised that full window updates cause such
a performance hit.  Most toolkits do full window updates on every redraw.
Anyway, I'm glad it's fixed. I've merged it to master now

> Solar after "[x11] Only redraw the parts that are updated"
> 10896 root      20   0 30672  16m 5496 R 65.0  1.1   0:06.84 plymouthd
>  1807 root      20   0 72856  45m  12m R 14.9  3.0   4:09.42 Xorg
>
> Solar after "[x11] Throttle plymouth to X server"
> 11135 root      20   0 30672  16m 5488 R 58.0  1.1   0:06.39 plymouthd
>  1807 root      20   0 73112  46m  12m S 26.5  3.1   4:14.13 Xorg
>
>> I changed this to do a 1x1 XGetImage call, which is a little more
>> reliable way of ensuring things are throttled than the XSync call.
>
> It is hitting the X a little itself.
I will need to investigate this more.  XGetImage is a very costly call, but
I wouldn't expect it to be costly for a 1 pixel readback.  We may want to
drop this patch.

Anyway, thanks a ton for implementing this.  It's something I've
wanted for a long time.

--Ray