[PATCH 2/2] [scripts] Don't hardcode LIBEXECDIR and DATADIR paths

Ray Strode halfline at gmail.com
Tue Mar 2 11:28:56 PST 2010


Hi,

On Tue, Mar 2, 2010 at 1:13 PM, Scott James Remnant <scott at ubuntu.com> wrote:
> The scripts hard-coded the paths for LIBEXECDIR and DATADIR, unless
> passed as environment variables.  Instead of doing this, which breaks
> if plymouth is installed outside of /usr, set these derived from the
> configure @libexecdir@ and @datadir@ variables just as we do for
> pkg-config, etc.
>
> Since we use so many variables, it makes more sense to generate these
> scripts from config.status rather than having special Makefile rules
> for them.

I guess this is okay. I'm a little uneasy about config.status since it
doesn't fully expand its arguments.

That means we have to guess which things go up top (e.g.
datarootdir="@datarootdir@"). The sed from Makefile.am technique is
pretty widespread, but i'm not super tied to it.

We can do the config.status thing, but it may end up spontaneously
breaking down the road.  I'm not too worried about it, though.  If
things break we can just fix them.

--Ray


More information about the plymouth mailing list