[PATCH 09/21] [terminal] drop next_active_vt

Ray Strode halfline at gmail.com
Thu Mar 18 13:06:27 PDT 2010


Hi,

On Thu, Mar 18, 2010 at 3:54 PM, Scott James Remnant <scott at ubuntu.com> wrote:
> As far as I can tell, even X doesn't call VT_WAITACTIVE
It didn't used to on the shutdown path until a couple of years ago.
It's always done it on the start up path, I think, though.

It was added to fix races between one X quitting and another starting
(some issue Red Hat was hitting with RHGB)
>
> You need it if you call VT_ACTIVATE and then expect to be on the VT you
> activated, since that ioctl() returns immediately and doesn't block.
> There are reasons you might need that, synchronous code for example; or
> if you need to use one of the silly ioctl()s that require that the VT be
> the foreground one (font and keymap settings, etc.)
Right, I thought there was some book keeping reason as well, though,
for the kernel to clean up some allocated resource, but I dug a bit
and couldn't find anything to support that.  So I think I'm probably
wrong.

> So yeah, in summary, this is better and I'm pretty sure it's valid (it
> certainly works :p)
Good enough for me.

--Ray


More information about the plymouth mailing list