What does check_for_consoles do?

Ray Strode halfline at gmail.com
Thu Apr 21 11:51:40 PDT 2011


Hey,

On Thu, Apr 21, 2011 at 3:38 AM, fykcee1 at gmail.com <fykcee1 at gmail.com> wrote:
> Thanks for the reply.
> I guess we should filter out 'vt' in check_for_consoles, since a 'vt'
> isn't a serial console. I've made a patch for it, seems working fine.
So reading through this patch, it seems to do a few things:

1)
+      if (strncmp (console_string, "/dev/", strlen ("/dev/")) == 0)
+        console_string += strlen ("/dev/");
Chop off the /dev/ prefix before adding the console to the hash table.

This is fine and a useful change by itself because say

console=/dev/ttyS0 console=ttyS0

on the kernel command line should be coalesced into one entry and they
aren't right now.

2) Prevent e.g. console=tty0 from forcing details.  Sounds fine.

3) Switching to stack allocated memory instead of heap allocated
memory.  I don't really
care either way about this.

4) Prevent the default_tty from getting a text display associated with
it.  This will break the "text" plugin I think. Or am I missing
something in my read through?

Could you post 1, 2, and maybe 3 as separate commits?  If not, I'll
split them up.

--Ray


More information about the plymouth mailing list