[PATCH] Add "--nowait" option to plymouth

[Ray Strode]

Hey,


On Fri, Jul 15, 2011 at 12:39 AM, fykcee1 at gmail.com <fykcee1 at gmail.com> wrote:
> The attachment is a patch that adds '--nowait' option to plymouth,
> which will enable plymouth not to wait for reply of plymouthd.
seems reasonable enough to me.

Your patch has a little incongruity though.  --wait is a global
option, but you create a "wait" argument for each request.  If --wait
is global, it should probably be a separate method on the client
object, e.g. ply_boot_client_set_wait_for_replies (client...FALSE), or
an argument to ply_boot_client_new.

I also think something like --quit-before-replies would be better than
--nowait because we have a "wait" option already that isn't the
opposite of this new option.

Speaking of --wait, it doesn't really make since to be combined with
--nowait.   That suggests maybe --nowait should be an opition on the
subcommands that it makes sense for instead of a global thing.   If
you go that route, then keeping the wait argument for each request
probably makes sense (but adds a bit more churn to the code).  Either
way seems fine to me though.

--Ray