[PATCH 1/4] ply-text-display: support bright colors

Jan Engelhardt jengelh at inai.de
Tue Jul 31 08:37:57 PDT 2012


On Tuesday 2012-07-31 17:22, Ray Strode wrote:
>
>If a driveby user sees
>
>terminal_write ("\x1b\x5b%d;%d%um", hi, FG_COLOR_BASE + color,
>BG_COLOR_BASE + display->bg_color);
>
>then they'll have to decode the line noise and figure out what it means.

Add a comment? Though it borders on Obviousness to say
 /* This is the VT100 code for changing $foo */
given the function is all about setting color.

>> Because the "0" in \e[0;...m, which is emitted when going from bold to
>> non-bold, resets everything, including bgcolor?
>Instead of using \e[0m maybe use \e[22m ?  That should just toggle
>high brightness off, but leave bg color alone, I think.

Let's use that.


More information about the plymouth mailing list