[PATCH] Add support for scrolling boot log messages

[Pali Rohár]

On Saturday 23 November 2013 19:13:39 Pali Rohár wrote:
> On Wednesday 27 June 2012 21:51:51 Ray Strode wrote:
> > hi,
> >
> > 
> >
> > > and current argument is status name (const char *).
> > > Command and argument are passing to function
> > > ply_boot_client_queue_request.
> > >
> > > 
> > >
> > > How to add to this protocol/function operation-id
> > > argument?
> >
> > 
> >
> > So the code does:
> > 
> >   request_string = NULL;
> >   asprintf (&request_string, "%s\002%c%s", request->command,
> >             (char) (strlen (request->argument) + 1),
> >
> > request->argument); *request_size = strlen (request_string)
> > + 1;
> >
> > 
> >
> > I guess I would change it to:
> > 
> >   request_string = NULL;
> >   asprintf (&request_string, "%s\002%c%s\035%c%s",
> >
> > request->command, (char) (strlen (request->argument_1) + 1),
> > request->argument_1, (char) (strlen (request->argument_2) +
> > 1), request->argument_2); *request_size = strlen
> > (request_string) + 1;
> >
> > 
> >
> > (or so)
> >
> > 
> >  \035 is just a random control character from "man ascii"
> >that
> >
> > seemed reasonable enough to use
> >
> > 
> >
> > --Ray
> 
> Hello Ray,
> 
> after long time I finished my patch for boot log messages. I
> added register-operation and unregister-operation commands
> for it as you suggested. Here is patch generated by git
> format-patch:
> 
> From a0a797d05208c8a134e5f6cfe185965b5f788755 Mon Sep 17
> 00:00:00 2001 From: =?UTF-8?q?Pali=20Roh=C3=A1r?=
> <pali.rohar at gmail.com> Date: Sat, 23 Nov 2013 17:39:53 +0100
> Subject: [PATCH] Add support for operation log messages
> 
> This patch adding support for operation log messages and
> updating upstart bridge code to use it. This is usefull for
> verbose log output (e.g daemon starting, stopping).
> 
> Example:
> 
>  Register operation ssh:
>  $ plymouth register-operation --operation-id=ssh
> --name='Starting OpenSSH server ssh'
> 
>  Set state of operation ssh to wait:
>  $ plymouth update --operation-id=ssh --status="wait"
>  Details plugin will show: 'Starting OpenSSH server ssh...
> [wait]'
> 
>  Set state of operation ssh to done:
>  $ plymouth update --operation-id=ssh --status="done"
>  Details plugin will show: 'Starting OpenSSH server ssh...
> [done]'
> 
>  Unregister operation ssh:
>  $ plymouth unregister-operation --operation-id=ssh

Hello, can you review my patch?

-- 
Pali Rohár
pali.rohar at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20131231/22c62dab/attachment.pgp>