[Pm-utils] Re: pm-utils' 55battery: WTF?

David Zeuthen david at fubar.dk
Tue Mar 13 11:45:02 PDT 2007


On Tue, 2007-03-13 at 19:35 +0100, Stefan Seyfried wrote:
> 		dbus-send --print-reply --system --reply-timeout=2000 \
> 			--dest=org.freedesktop.Hal $x \
> 			org.freedesktop.Hal.Device.Rescan string:$x

[...]

> so what does this monster do? Why is this needed? It stealy me half a second
> of resume time, so it'd better be worth it ;-)
> 
> If somebody can convince me that it is really needed, then it needs at least
> a comment telling why this is the case.

It tells HAL to rescan the battery - in case someone changed the battery
we want the new serial number etc... if I recall Peter's reasoning
correctly. I think this check is better done in HAL than in pm-utils; it
doesn't make sense to make pm-utils call into HAL at all - Peter, is
this fine with you? 

If so, I'll make this change in HAL for 0.5.9 (and I'll make the async
too!).

     David




More information about the Pm-utils mailing list