[Pm-utils] fix cpufreq governor setting on dualcore machines

Holger Macht hmacht at suse.de
Wed Mar 14 08:55:15 PDT 2007


On Wed 14. Mar - 11:36:41, Peter Jones wrote:
> On Tue, 2007-03-13 at 18:23 +0100, Stefan Seyfried wrote:
> 
> > https://bugzilla.novell.com/show_bug.cgi?id=227854#c13 sums it up nicely.
> > On dualcore cpus, where the governor setting affects more than one core,
> > the cpufreq policy will be set to performance after resume.
> 
> The idea is certainly correct, but I still hate setting the governor to
> "performance".  Realizing that we're never going to agree on this, I've
> added a config variable "TEMPORARY_CPUFREQ_GOVERNOR" that distros can
> set in 'defaults' (but I have not set it there), so that you can at
> least easily override my stubbornness.

I think you never really explained why you do not like setting it to
performance. Ok, your choice which governor to take, but userspace is just
plain wrong here.

If frequency is at minimum at the time the userspace governor is set, it
will never increase during suspend image creation. I can imagine that this
will slow down compression quite heavily.

Having TEMPORARY_CPUFREQ_GOVERNOR variable doesn't really help here, we've
to do a patch in any case. Well, of course, you've the final say. Maybe
it's just me you doesn't understand it...

Regards,
	Holger


More information about the Pm-utils mailing list