[Pm-utils] [PATCH 4/6] Do not overwrite the log, just append to it.

[Stefan Seyfried]

Victor Lowther wrote:
> On Mon, 2008-04-28 at 16:00 +0200, Stefan Seyfried wrote:
>> Victor Lowther wrote:
>>> It might come in handy to have more than one run's worth of data in the log.
>> Unless your disk runs full.
>> NAK.
> 
> Please, that is a lame reason to NAK.  pm-suspend.log is much less
> likely to fill the disk than (say) /var/log/messages.

This is a lame excuse IMVHO, especially if i take a look at what dubious code
"fixes" have gone into pm-utils lately, this is much more security relevant
than most of those other "improvements" ;-)

>  If it is really a
> serious concern, patches to let us use syslog for logging (and get log
> rotation for free!) are welcome.

I don't really care.

JFTR: in the few years i am now supporting users in bugreports and
mailinglists wrt. suspend, i never thought "Wow - if i only had the log before
the last try, this would be very helpful!". Exactly the opposite.
-- 
Stefan Seyfried
R&D Team Mobile Devices            |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)