[Pm-utils] [PATCH 4/4] Clean up generated files and put *.in files in the tarball

Dan Nicholson dbn.lists at gmail.com
Thu Feb 14 09:37:35 PST 2008


On Thu, Feb 14, 2008 at 8:04 AM, Michael Biebl <mbiebl at gmail.com> wrote:
> The current Makefile.am are not quite correct.
>  They put the generated files into the tarball, but not the *.in files.
>  They also don't clean up some of the generated files.
>
>  This patch address that. It also simplifies the Makefile.amS a bit and
>  uses a more consistent naming for the install dirs.

This is good (I hadn't noticed before about the missing .in files in
dist), but I think there are two improvements still to make:

- The transformed scripts (e.g., pm-action) are also distributed,
meaning you'll have a copy of whoever did `make dist'. This can be
avoided by using nodist_*_SCRIPTS for the ones that are transformed.
The CLEANFILES setting has to change to match.

- Instead of adding the non-transformed scripts into EXTRA_DIST, add
the dist_ prefix to their *_SCRIPTS variables.

What do you think?

--
Dan


More information about the Pm-utils mailing list