[Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

[Michael Biebl]

2008/2/15, Victor Lowther <victor.lowther at gmail.com>:

>
>  -[ -f /proc/acpi/ibm/led ] || exit 1

I like explicitly returning 1, because you immediately see, that we
return 1 in case we don't find the required resource. (This comment is
true for #13, #11, #9, #7, #6)

>  +[ -f /proc/acpi/ibm/led ] || exit

This is imho harder to read and understand. So I vote against removing
the explicit "exit 1".

>   case "$1" in
>         thaw|resume)
>  @@ -9,5 +9,3 @@ case "$1" in
>         *)
>                 ;;
>   esac
>  -
>  -exit $?

Instead of exit $?, I'd say we should return 0 here. So we have a
defined return code of 0, when we have reached the end of the script.

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?