[Pm-utils] [PATCH 07/17] Added an additional check for NetworkManager, removed redundant exit call.

[Victor Lowther]

On Fri, Feb 15, 2008 at 06:38:09AM -0800, Dan Nicholson wrote:
> On Mon, Feb 11, 2008 at 1:50 PM, Victor Lowther
> <victor.lowther at gmail.com> wrote:
> > ---
> >   pm/sleep.d/10NetworkManager |    4 +---
> >   1 files changed, 1 insertions(+), 3 deletions(-)
> >
> >  diff --git a/pm/sleep.d/10NetworkManager b/pm/sleep.d/10NetworkManager
> >  index d1ad677..5c526eb 100755
> >  --- a/pm/sleep.d/10NetworkManager
> >  +++ b/pm/sleep.d/10NetworkManager
> >  @@ -2,7 +2,7 @@
> >
> >   . "${PM_FUNCTIONS}"
> >
> >  -command_exists dbus-send || exit 1
> >  +command_exists dbus-send && command_exists NetworkManager || exit
> 
> I'm not a big fan of this change. Using dbus-send is already a more
> powerful way to contact NetworkManager then relying on $PATH. What if
> I'm playing around with NM and my daemon is in /opt/nm-testing/sbin?
> What if I'm running a daemon I called NetworkManager2?

Fair enough.  The change was intended to cover the situation in which
dbus is installed and NetworkManager is not.  If this patch is
insufficently generic, I have no problem dropping it.
 
> --
> Dan

-- 
Victor Lowther
Ubuntu Certified Professional