[Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

Michael Biebl mbiebl at gmail.com
Fri Feb 15 10:10:51 PST 2008


2008/2/15, Victor Lowther <victor.lowther at gmail.com>:
> On Fri, Feb 15, 2008 at 09:07:19AM +0100, Michael Biebl wrote:
>  > 2008/2/15, Victor Lowther <victor.lowther at gmail.com>:
>  >
>  > >
>  > >  -[ -f /proc/acpi/ibm/led ] || exit 1
>  >
>  > I like explicitly returning 1, because you immediately see, that we
>  > return 1 in case we don't find the required resource. (This comment is
>  > true for #13, #11, #9, #7, #6)
>
>
> However, nothing in pm-utils notices or cares what the hooks return
>  right now.  It used to, but the refactoring I performed on run_hooks a
>  couple of patch series ago got rid of that.
>

Well, I thought it might be useful if we could differentiate between
hooks that ran successfully or failed. This could be especially handy
for debugging. We could write to the log file which hooks failed and
which succeeded, etc.

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


More information about the Pm-utils mailing list