[Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

Michael Biebl mbiebl at gmail.com
Sat Feb 16 10:08:27 PST 2008


2008/2/16, Victor Lowther <victor.lowther at gmail.com>:
>
> Reserving an exit code for "not applicable" or "skipped" woud be fine,
> but all those "|| exit 1" and the final "exit 0" are redundant.

Not quite. Using || exit 1 normalizes the return code in case of an error.
Take 20video as an example.
Running vbetool could give you an return code other than 1 in case of
an error ( I haven't actually checked the code, but you get the idea),
maybe even 2 (ie. the code we reserve for skipped).
So the || exit 1 is not redundant.

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


More information about the Pm-utils mailing list