[Pm-utils] [PATCH RFC] Merge 20video and 99video

[Michael Biebl]

2008/2/20, Victor Lowther <victor.lowther at gmail.com>:
> On Tue, Feb 19, 2008 at 01:50:29PM +0000, Richard Hughes wrote:
>  > On Sat, 2008-02-16 at 18:53 -0600, Victor Lowther wrote:
>  > > After examining the source to s2ram and seeing how it does the video
>  > > quirk handling, I cannot see why 20video an 99video are seperate
>  > > hooks.
>  >
>  > The ordering must be preserved - and we want to kill the video last and
>  > bring it up first.
>
>
> That makes no sense whatsoever, then -- 20video saves state early in the
>  sleep cycle, and 99video restores it first thing in the wake cycle.
>
>  Not only is it counterintuitive, it is a race condition begging to
>  happen -- we save state, then we beg for potentially drastic things to
>  happen by stopping services and unloading modules, we sleep, then we
>  restore state before having loaded modules (including potentially video
>  card drivers).
>
>  If you want to kill video last, it should be in 99video, and if you want
>  to bring it back first it should also be in 99video.  At least then the
>  state we save will be saved from an environment that much more closely
>  approximates the one we restore it in.
>

What's the status on this?
I'd vote for merging 20video into 99video as proposed by Victor.

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?