[Pm-utils] [PATCH RFC] Merge 20video and 99video

[Victor Lowther]

On Wed, Feb 27, 2008 at 07:28:26PM -0600, Victor Lowther wrote:
> On Wed, Feb 27, 2008 at 06:24:07PM +0100, Michael Biebl wrote:
> > 2008/2/17, Victor Lowther <victor.lowther at gmail.com>:
> > > After examining the source to s2ram and seeing how it does the video
> > >  quirk handling, I cannot see why 20video an 99video are seperate hooks.
> > >
> > >  This patch aims to rectify that. It does the following things:
> > >  * Merge the functionality of 20video and 99video by folding the state
> > >   saving that 20video does into 99video.
> > >  * Modifies the state saving and restoring code in pm/functions.in to
> > >   make savestate also accept the state to save on stdin.  This allows
> > >   savestate and restorestate to be symmetric and to ensure that they
> > >   can handle any type of data without it getting mangled by using a
> > >   shell variable as an intermediate stage.
> > >  * Make 99video use savestate and restorestate to save and restore vbe
> > >   state information across suspend/resume instead of using their own
> > >   temporary files.
> > >  * Add support for --quirk-none.  The latest HAL can run us with it, but
> > >   we did not handle it.  We do now.
> > >  * While I am at it, fix up 94cpufreq to use the new state handling
> > >   functionality. This also improves readability.
> > >
> > 
> > Hi Victor,
> > 
> > I support the idea of merging 20video into 99video, but your patch
> > does a lot more than that.
> > Could you split them into smaller patches, where each patch addresses
> > the above points separately.
> 
> No problem.  

Done.  The new patch series has everything except the 94cpufreq changes.

-- 
Victor Lowther
Ubuntu Certified Professional