[Pm-utils] [patch commit] [011] POSIXification of pm-utils

[Victor Lowther]

On Jan 27, 2008 8:37 PM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2008/1/27, Victor Lowther <victor.lowther at gmail.com>:
>
> > Use file globbing instead of trying to parse the output of ls, change
> > default governor from "userspace" to "performance" because performance
> > is the compiled-in default for just about everything that uses
> > cpufreq.
>
> +               grep -q "$GOVERNOR" "$x/cpufreq/scaling_available_governors" \
> +                       || gov="performance"
>
> Isn't this a typo, and it should be "$gov" instead of "$GOVERNOR"

Yes, it is a typo.  Good catch. Patch attached.

> And to change the default governor during suspend/hibernate, I'd say
> you have to use
>
> --- a/pm/functions
> +++ b/pm/functions
> @@ -15,7 +15,7 @@ HIBERNATE_RESUME_POST_VIDEO=no
>  INHIBIT=/var/run/pm-utils.inhibit
>  PM_LOGFILE=${PM_LOGFILE:=/var/log/pm-suspend.log}
>  SUSPEND_MODULES=""
> -TEMPORARY_CPUFREQ_GOVERNOR="userspace"
> +TEMPORARY_CPUFREQ_GOVERNOR="performance"
>
>  # Use c sort order
>  export LC_COLLATE=C
>
> || gov="performance" is only a fallback.

Precisely.  The code I have is by design -- performance is the
fallback governor.  The commit comment is incorrect in this case. :)

> Cheers,
> Michael
>
> --
>
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 018-fix-typo-in-94cpufreq.patch
Type: text/x-patch
Size: 408 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/pm-utils/attachments/20080127/48425516/attachment.bin